Skip to content

Remove e2e test project, bump Angular deps to 21.x #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RobbieTheWagner merged 3 commits into from
Jan 14, 2026
Merged

Remove e2e test project, bump Angular deps to 21.x #2864

RobbieTheWagner merged 3 commits into from
Jan 14, 2026

Conversation

@muhamedkarajic
Copy link
Contributor

@muhamedkarajic muhamedkarajic commented Dec 28, 2025 •
edited by coderabbitai bot
Loading

Note there are 2 commits:

  1. First commit is cause of vulnerabilities of protractor & therefore removed (cause it was anyways not used). Afterwards I still had to use npm audit fix --force.
  2. Second one is the Angular update itself. No npm audit fix was necessary.

Summary by CodeRabbit

  • Documentation

    • Added Angular 21 compatibility to the supported versions list.

  • Chores

    • Upgraded Angular framework, CLI, tooling and TypeScript-related packages to 21.x/5.9.
    • Bumped package peer dependencies to align with Angular 21.
    • Removed legacy end-to-end testing setup and associated configs/tooling.

✏️ Tip: You can customize this high-level summary in your review settings.

@muhamedkarajic
Release v21.0.0 (shipshapecode#2859)
11423e5 
Removed protractor cause of vulnerabilities.

NOTE: Used `npm audit fix --force`
@muhamedkarajic
Release v21.0.0 (shipshapecode#2859)
90f4485 
Updated to Angular v21.0.0 & done remaining setup changes.
@coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

Upgrades project dependencies and tooling from Angular 20.x to 21.x (including peerDependencies), updates TypeScript/tooling versions, adds README compatibility entry for Angular 21, and removes the Protractor e2e project and its associated files/configuration.

Changes

Cohort / File(s) Summary
README
README.md		 Added Angular 21 compatibility entry to the Compatibility list.
Dependency and tooling updates
package.json, projects/shepherd/package.json		 Upgraded Angular packages and CLI/tooling to 21.x, bumped TypeScript and related tooling, updated eslint/ng-packagr versions; updated peerDependencies in projects/shepherd/package.json to ^21.0.0; removed Protractor from devDependencies.
Workspace config
angular.json		 Removed the shepherd-tester-e2e project configuration block from the projects section.
E2E project removal
projects/shepherd-tester-e2e/.eslintrc.json, projects/shepherd-tester-e2e/protractor.conf.js, projects/shepherd-tester-e2e/src/app.e2e-spec.ts, projects/shepherd-tester-e2e/src/app.po.ts, projects/shepherd-tester-e2e/tsconfig.e2e.json		 Deleted Protractor e2e configuration, specs, page object, tsconfig, and eslintrc for the removed e2e project.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰
I hopped through packages, pom-poms in tow,
From twenty to twenty-one — what a glow!
Old Protractor footprints fade in the grass,
New versions prance forward, quick as a dash.
🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: removing the e2e test project and upgrading Angular dependencies to version 21.x.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90f4485 and 9a1c434.

📒 Files selected for processing (1)
  • projects/shepherd/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • projects/shepherd/package.json

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@muhamedkarajic muhamedkarajic mentioned this pull request Dec 28, 2025
Closed
@muhamedkarajic muhamedkarajic changed the title Release v21.0.0 (#2859) Release v21.0.0 Dec 28, 2025
@RobbieTheWagner RobbieTheWagner changed the title Release v21.0.0 Remove e2e test project, bump Angular deps to 21.x Jan 14, 2026
RobbieTheWagner
RobbieTheWagner reviewed Jan 14, 2026
View reviewed changes
@RobbieTheWagner RobbieTheWagner merged commit 6d1dea9 into shipshapecode:main Jan 14, 2026
3 checks passed
This was referenced Jan 14, 2026
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees

No one assigned

Labels

breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@muhamedkarajic @RobbieTheWagner